From: Stefan Beller <sbeller@google.com>
Date: Tue, 16 Dec 2014 20:51:47 GMT
Subject: Re: [PATCHv2 6/6] t5543-atomic-push.sh: add basic tests for atomic pushes
Message-ID: <CAGZ79kb6JqJRJYhx=ypo+3WJAbu1uy_LSCPc+a+3=wW5EKWhZw@mail.gmail.com>
In-Reply-To: <xmqq7fxr9vc7.fsf@gitster.dls.corp.google.com>

On Tue, Dec 16, 2014 at 12:46 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Stefan Beller <sbeller@google.com> writes:
>
>> On Tue, Dec 16, 2014 at 11:46 AM, Junio C Hamano <gitster@pobox.com> wrote:
>>
>>>
>>> Seeing that all callers of test_ref_upstream computes $2 as
>>>
>>>         git -C workbench rev-parse --verify <something>
>>>
>>
>> Only in the first tests, where this should be the case after push.
>> In the failure tests, we go with HEAD@{N} which needs to be computed
>> inside the workbench repo.
>
> Aren't we saying the same thing?  The suggested alternative is to do
> the "git -C workbench rev-parse" bit inside the helper.

Now I am saying the same. (I finally understood what you were saying)

Will incorporate in a reroll.