From: Stefan Beller <sbeller@google.com>
Date: Fri, 10 Aug 2018 21:52:22 GMT
Subject: Re: [PATCH 6/7] submodule--helper: replace connect-gitdir-workingtree by ensure-core-worktree
Message-ID: <CAGZ79kb+QyCuBw+e8ShU3Ts9GL+bhzb=i2F+5B0jb9eWk5Sj1w@mail.gmail.com>
In-Reply-To: <20180810214703.GB211322@google.com>

> > +             cfg_file = xstrfmt("%s/config", subrepo.gitdir);
>
> As I mentioned here:
> https://public-inbox.org/git/20180807230637.247200-1-bmwill@google.com/T/#t
>
> This lines should probably be more like:
>
>   cfg_file = repo_git_path(&subrepo, "config");
>

Why? You did not mention the benefits for writing it this way
here or on the reference. Care to elaborate?