From: Stefan Beller <sbeller@google.com>
Date: Wed, 09 May 2018 18:52:30 GMT
Subject: Re: [PATCH v2 0/2] gitk: improve handling of submodules in the file list panel
Message-ID: <CAGZ79kaqp2sOU76+uQOvzvh_ojJf1O2YqmnmAU2UM-Jm+ZFQ8Q@mail.gmail.com>
In-Reply-To: <cover.1525868167.git.raa.lkml@gmail.com>

On Wed, May 9, 2018 at 5:35 AM, Alex Riesen
<alexander.riesen@cetitec.com> wrote:
> From: Alex Riesen <raa.lkml@gmail.com>
>
> Currently, the submodule entries in the file list panel are mostly ignored.
> This series attempts to improve the situation by showing part of submodule
> history when focusing it in the file list panel and by adding a menu element
> to start gitk in the submodule (similar to git gui).
>
> This iteration does not address the behaviour of file list panel in tree mode
> when gitk is started from a subdirectory (gitk strictly limits the file
> listing to the files in that repository, without a way out).
> I would like to hear some more opinions regarding changing its behaviour to
> always list the full tree.
>
> Alex Riesen (2):
>   gitk: show part of submodule log instead of empty pane when listing
>     trees
>   gitk: add an option to run gitk on an item in the file list

both patches look ok, to my untrained eye.