From: Stefan Beller <sbeller@google.com>
Date: Thu, 16 Mar 2017 23:25:41 GMT
Subject: Re: [PATCH v4 03/10] submodule sync: skip work for inactive submodules
Message-ID: <CAGZ79kaqeR3aNT5qVh0Zz1MmCJ-+WpRMLZAt23DMxU53kpr_Ew@mail.gmail.com>
In-Reply-To: <CAGZ79kaP9ob+qvso=pV=PPaB5guaW18w297xA+bfDFASV0zibg@mail.gmail.com>

On Thu, Mar 16, 2017 at 4:24 PM, Stefan Beller <sbeller@google.com> wrote:
> On Thu, Mar 16, 2017 at 3:29 PM, Brandon Williams <bmwill@google.com> wrote:
>> Sync does some work determining what URLs should be used for a submodule
>> but then throws this work away if the submodule isn't active.  Instead
>> perform the activity check earlier and skip inactive submodule in order
>> to avoid doing unnecessary work.
>>
>> Signed-off-by: Brandon Williams <bmwill@google.com>
>> ---
>
>> +               # skip inactive submodules
>> +               if ! git config "submodule.$name.url" >/dev/null 2>/dev/null
>
> As a stand alone patch, this would look good to me.
> But with the goal of this patch series in mind (which is to add
> more options to enable a submodules "active" state), this
> should rather be "submodule--helper is-active" here?
>

I spoke too early. this happens in the next patch.

ok, thanks!
Stefan