From: Stefan Beller Date: Thu, 14 Jun 2018 19:23:09 GMT Subject: Re: [PATCH v2 3/8] upload-pack: test negotiation with changing repository Message-ID: In-Reply-To: <20180613213925.10560-4-bmwill@google.com> On Wed, Jun 13, 2018 at 2:39 PM Brandon Williams wrote: > > Add tests to check the behavior of fetching from a repository which > changes between rounds of negotiation (for example, when different > servers in a load-balancing agreement participate in the same stateless > RPC negotiation). This forms a baseline of comparison to the ref-in-want > functionality (which will be introduced to the client in subsequent > commits), and ensures that subsequent commits do not change existing > behavior. > > As part of this effort, a mechanism to substitute strings in a single > HTTP response is added. This patch looks good to me. Thanks, Stefan