From: Stefan Beller Date: Tue, 19 Jun 2018 18:18:25 GMT Subject: Re: [PATCH] format-patch: clear UNINTERESTING flag before prepare_bases Message-ID: In-Reply-To: <20180604150543.7304-1-xiaolong.ye@intel.com> On Mon, Jun 4, 2018 at 8:09 AM Xiaolong Ye wrote: > > When users specify the commit range with 'Z..C' pattern for format-patch, all > the parents of Z (including Z) would be marked as UNINTERESTING which would > prevent revision walk in prepare_bases from getting the prerequisite commits, > thus `git format-patch --base Z..C` won't be able to generate > the list of prerequisite patch ids. Clear UNINTERESTING flag with > clear_object_flags solves this issue. This makes sense; Reviewed-by: Stefan Beller