From: Stefan Beller <sbeller@google.com>
Date: Thu, 09 Feb 2017 17:39:42 GMT
Subject: Re: [PATCH 5/5] read_loose_refs(): read refs using resolve_ref_recursively()
Message-ID: <CAGZ79kaitf2NddaKK2WQQMnU-aCEOGNGBnTjufWs9iUWwbeX4g@mail.gmail.com>
In-Reply-To: <024d6b2e5ca1ffa876c2911e6d9d0bb4f6091730.1486629195.git.mhagger@alum.mit.edu>

On Thu, Feb 9, 2017 at 5:27 AM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
> There is no need to call read_ref_full() or resolve_gitlink_ref() from
> read_loose_refs(), because we already have a ref_store object in hand.
> So we can call resolve_ref_recursively() ourselves. Happily, this
> unifies the code for the submodule vs. non-submodule cases.
>
> This requires resolve_ref_recursively() to be exposed to the refs
> subsystem, though not to non-refs code.
>
> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
> ---

Looks good,
Stefan