From: Stefan Beller <sbeller@google.com>
Date: Mon, 13 Aug 2018 18:24:52 GMT
Subject: Re: [PATCH 3/4] range-diff: make use of different output indicators
Message-ID: <CAGZ79kainPmtHWT+11+34f4F2pGD3+too5SrG547z6HRFYjK-A@mail.gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.1808131348120.71@tvgsbejvaqbjf.bet>

> >                       strbuf_addbuf(&buf, &line);
> > +             }
>
> My preliminary reading (I sadly lack the time to pull your branch and play
> with it) suggests that this works, although I have to admit that X/Y/Z
> would confuse me in 6 months from now, as they do not really read like
> diff markers but like plain text. I could imagine that '>', '<' and '#'
> would not impart that confusion on me.

Thanks for that suggestion! (I'll change it and add a comment)