From: Stefan Beller <sbeller@google.com>
Date: Thu, 13 Jul 2017 18:51:44 GMT
Subject: Re: [PATCH 05/15] ref-filter: abstract ref format into its own struct
Message-ID: <CAGZ79kag1B37FBrmDzbRFNVODHp=n1h=xSq_pi1b7Fs4wLoRBg@mail.gmail.com>
In-Reply-To: <20170713150118.eof3xgu4zujmo6u6@sigill.intra.peff.net>

On Thu, Jul 13, 2017 at 8:01 AM, Jeff King <peff@peff.net> wrote:

>  builtin/branch.c       | 14 +++++++-------
>  builtin/for-each-ref.c | 22 ++++++++++++----------
>  builtin/tag.c          | 30 ++++++++++++++++--------------
>  builtin/verify-tag.c   | 12 ++++++------
>  ref-filter.c           | 22 ++++++++++++----------
>  ref-filter.h           | 22 +++++++++++++++++-----
>  6 files changed, 70 insertions(+), 52 deletions(-)

The patch looks good to me. So some off-topic comments:
I reviewed this patch from bottom up, i.e. I started looking at
ref-filter.h, then  ref-filter.c and then the rest. If only you had formatted
the patches with an orderfile. ;)