From: Stefan Beller <sbeller@google.com>
Date: Wed, 30 May 2018 22:19:33 GMT
Subject: Re: [RFC PATCH 00/35] object-store: lookup_commit
Message-ID: <CAGZ79kaaObh50ff1fT3no=jsHde+ZyacKtgbFa8ht__Hg4SDsg@mail.gmail.com>
In-Reply-To: <6e18e6bb-cc11-a1b4-becb-4115df124284@gmail.com>

Hi Derrick,

> I went through the whole series and didn't find any issue with the code. The
> commit messages reference coccinelle scripts that I never saw, so those
> should be struck from the messages.

I fixed this locally. I'll wait for more reviews to resend though.

>
> If anyone else plans to review, these two commits are worth special
> attention compared to the others:
>
> [PATCH 27/35] commit-slabs: remove realloc counter outside of slab struct
> [PATCH 28/35] commit.c: migrate the commit buffer to the parsed object store

Thanks for pointing these out! patch 27 might even go on top of
nd/commit-slab-to-util.