From: Stefan Beller <sbeller@google.com>
Date: Thu, 09 Feb 2017 17:25:20 GMT
Subject: Re: [PATCH 4/5] files_ref_store::submodule: use NULL for the main repository
Message-ID: <CAGZ79kaWFmutihZ-7_xUOB2K3TR6f4Ap9z3LC8s=3YpxOOd5DQ@mail.gmail.com>
In-Reply-To: <111d663c0fd3e9669e7c28537f581833488ca4a6.1486629195.git.mhagger@alum.mit.edu>

On Thu, Feb 9, 2017 at 5:27 AM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
> The old practice of storing the empty string in this member for the main
> repository was a holdover from before 00eebe3 (refs: create a base class
> "ref_store" for files_ref_store, 2016-09-04), when the submodule was
> stored in a flex array at the end of `struct files_ref_store`. Storing
> NULL for this case is more idiomatic and a tiny bit less code.
>
> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
> ---

Makes sense!
Stefan