From: Stefan Beller <sbeller@google.com>
Date: Wed, 03 Aug 2016 23:22:42 GMT
Subject: Re: [PATCHv4 6/7] submodule--helper: add remote-branch helper
Message-ID: <CAGZ79kaVB_aSuUK-jzAaq_ZHMh-P8hrjGjkkQwr0eH7u9xZj-Q@mail.gmail.com>
In-Reply-To: <xmqq8twd78fm.fsf@gitster.mtv.corp.google.com>

On Wed, Aug 3, 2016 at 4:13 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Stefan Beller <sbeller@google.com> writes:
>
>> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
>> index fb90c64..9be2c75 100644
>> --- a/builtin/submodule--helper.c
>> +++ b/builtin/submodule--helper.c
>> @@ -899,6 +899,39 @@ static int resolve_relative_path(int argc, const char **argv, const char *prefix
>>       return 0;
>
> I wonder who lost the leading SP before the tab here.  Will manually
> fix, so this is not a reason to force resending, but you may want to
> make sure there is no systemic cause to corrupt your future patches.

It's not a systematic issue, it was user error.
(I started writing out a story, but it got long)

Thanks,
Stefan

>
> Thanks.