From: Stefan Beller <sbeller@google.com>
Date: Wed, 01 Jun 2016 20:59:06 GMT
Subject: Re: [BUG] git-submodule has bash-ism?
Message-ID: <CAGZ79kaUHm==ZjRwD3MTnCXKAWUHszb4PPF=S4Y-TD2e4eBsTw@mail.gmail.com>
In-Reply-To: <xmqq8tyoy6se.fsf@gitster.mtv.corp.google.com>

On Wed, Jun 1, 2016 at 1:48 PM, Junio C Hamano <gitster@pobox.com> wrote:
> John Keeping <john@keeping.me.uk> writes:
>
>> Absolutely, my original point should have been prefixed with: I wonder
>> if the reason we haven't had any problems reported is because ...
>>
>> And we've got lucky because the clobbering of global variables happens
>> not to matter in these particular cases.
>
> Ah, I did misunderstand why you were making that statement, and now
> I fully agree with your conclusion (which is what Jeff spelled out
> in the latest message) that the fact that we saw no breakage report
> is not a datapoint that everybody's shell supports "local" at all.
>
> Thanks for clarification.

I think both the use of submodules and the use of shells not supporting 'local'
is a minority in our current user base, so I am not surprised that nobody
complained about that, as the overlap between submodule users and
non-local shell users may even be zero.

The patch just sent, looks good to me for the minimal fix in the tests.

Thanks,
Stefan


> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html