From: Stefan Beller <sbeller@google.com>
Date: Mon, 12 Jun 2017 05:33:07 GMT
Subject: Re: [PATCH v1] dir: create function count_slashes
Message-ID: <CAGZ79kaKfdeyM41S2huGwYq8z3brRVpotA-CZzYe429-cA=mZg@mail.gmail.com>
In-Reply-To: <20170608180812.6678-1-pc44800@gmail.com>

On Thu, Jun 8, 2017 at 11:08 AM, Prathamesh Chavan <pc44800@gmail.com> wrote:
> Similar functions exist in apply.c and builtin/show-branch.c for
> counting the number of slashes in a string. Also in the later
> patches, we introduce a third caller for the same. Hence, we unify
> it now by cleaning the existing functions and declaring a common
> function count_slashes in dir.h and implementing it in dir.c to
> remove this code duplication.
>
> Mentored-by: Christian Couder <christian.couder@gmail.com>
> Mentored-by: Stefan Beller <sbeller@google.com>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> Signed-off-by: Prathamesh Chavan <pc44800@gmail.com>
> ---
> In future, I intend to use this function in builtin/submodule--helper.c
> as well, hence this change was introduced now.
>

Thanks for upstreaming this early!

I think this is a good change even
without the submodule work thrown into the soup as well,
but with the given promise to have it used a third time this
is a no-brainer later on.