From: Stefan Beller <sbeller@google.com>
Date: Mon, 23 Oct 2017 17:58:21 GMT
Subject: Re: [PATCH 1/2] t5526: check for name/path collision in submodule fetch
Message-ID: <CAGZ79kaFcPUUx0+tCnBzpssaN0c09eqjiDSbCTWLAVayaw1FOw@mail.gmail.com>
In-Reply-To: <20171023141644.GC85043@book.hvoigt.net>

>> +             git add submodule &&
>
> A small note even though this is not meant for inclusion: This would
> break when I start working on teaching 'git add' to set default values
> in .gitmodules when available.

Yes. I should have used something like:

    git update-index --add --cacheinfo 160000,$(git rev-parse HEAD),sub

as that is the real plumbing command to change a gitlink.

>
> But I guess I will discover a few other places, when starting that, that
> will break in the tests anyway.

Yes, I have the same suspicion. Thanks for reminding
me to use more plumbing!

Stefan