From: Stefan Beller Date: Thu, 28 Apr 2016 16:35:26 GMT Subject: Re: Strangeness with git-add and nested repositories Message-ID: In-Reply-To: On Wed, Apr 27, 2016 at 11:10 PM, Andrew J wrote: > Hi Stefan, > > On Wed, Apr 27, 2016 at 9:08 AM, Stefan Beller wrote: >> I think (pure speculation), that it the error is in the context >> (repository) switching logic. >> What happens if you alter the order, i.e. give testfile first and then >> the files in the nested >> repos? > > Interestingly, reversing the order produces the same result (the > testfile is added, the nested files are not). > > I've also noticed that running something like 'git status testfile > nestedfiles' results in the nested files being omitted from the git > status output; I'd expect them to be printed by git-status as > untracked files. So it appears the problem is not isolated to git-add. Looking at the code, git-add uses parse_pathspec, which is used my most commands[https://github.com/git/git/blob/master/builtin/add.c#L364] and I think that function needs to learn to cover paths for different repositories. Maybe we can pass in a flag, which allows parse_pathspec to get files from the different repos and then it's up to each command how to deal with that list of files. > > To give some context, my use case is that I have a parent project that > links to numerous chromium libraries, thus my parent project needs > access to many of chromium's headers at build time. I wanted to make > these headers available to other developers without them needing to > check out all of chromium. > So I add all the chromium headers to the parent project with something like: > find deps/chromium/src -name "*.h" | xargs git add -- > I was weirded out to find that many of the header files weren't being > added, as I've already described. > > I ultimately worked around this by doing: > find chromium/src -name "*.h" | xargs -n 1 git add > Since each file gets added separately, this is quite slow. So it'd be > nice if this little bug was fixed someday :) > > As you probably know, Chromium is comprised of many hundreds of nested > repos, so that aided in manifesting this issue. > > Thanks, > Andrew