From: Stefan Beller <sbeller@google.com>
Date: Mon, 16 Jul 2018 21:24:30 GMT
Subject: Re: [PATCH 11/16] test-reach: test get_merge_bases_many
Message-ID: <CAGZ79ka921=OxV9FUQWx2=yxeoSsWPzVMLYQR_2zq=DJ6=puRA@mail.gmail.com>
In-Reply-To: <7a3e3815c585dd3972e9bea6798a7664232157a3.1531746012.git.gitgitgadget@gmail.com>

> +test_expect_success 'get_merge_bases_many' '
> +       cat >input <<-\EOF &&
> +               A:commit-5-7
> +               X:commit-4-8
> +               X:commit-6-6
> +               X:commit-8-3
> +       EOF
> +       {
> +               printf "get_merge_bases_many(A,X):\n" &&
> +               git rev-parse commit-5-6 &&
> +               git rev-parse commit-4-7

Please call rev-parse only once, giving both tips as argument, i.e.

               printf "get_merge_bases_many(A,X):\n" &&
               git rev-parse commit-5-6 \
                             commit-4-7

ought to produce the same output

Thanks,
Stefan