From: Stefan Beller <sbeller@google.com>
Date: Mon, 14 Dec 2015 23:07:11 GMT
Subject: Re: [PATCH 2/8] xread: poll on non blocking fds
Message-ID: <CAGZ79ka6RB_RFxfTaXmV+9fyCmnnKcKZdRVB1fMywO97F1sbSw@mail.gmail.com>
In-Reply-To: <CAPig+cQoranAhJKSZm6jP-hYutkoXkf6461sY1v5NseQVTNL_g@mail.gmail.com>

On Mon, Dec 14, 2015 at 2:58 PM, Eric Sunshine <ericsunshine@gmail.com> wrote:
>> +                               /* We deliberately ignore the return value */
>
> This comment tells us what the code itself already says, but not why
> the value is being ignored. The reader still has to consult the commit
> message to learn that detail, which makes the value of the comment
> questionable.

It at least tells you it's not because of sloppiness. ;)
I'll elaborate that comment a bit further in a resend though.

Thanks,
Stefan