From: Stefan Beller <sbeller@google.com>
Date: Tue, 02 May 2017 04:18:55 GMT
Subject: Re: [PATCH 2/5] submodule_move_head: prepare env for child correctly
Message-ID: <CAGZ79ka61UjNkQ7Avhp5hvq39JvVX2_b2m=Rf7dTOe+XpkGUxA@mail.gmail.com>
In-Reply-To: <xmqqy3ugdnfu.fsf@gitster.mtv.corp.google.com>

On Mon, May 1, 2017 at 7:04 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Stefan Beller <sbeller@google.com> writes:
>
>> We forgot to prepare the submodule env, which is only a problem for
>> nested submodules. See 2e5d6503bd (ls-files: fix recurse-submodules
>> with nested submodules, 2017-04-13) for further explanation.
>>
>> Signed-off-by: Stefan Beller <sbeller@google.com>
>> ---
>
> Sounds good (if only because this makes it similar to other
> codepaths).
>
> Is this something whose breakage before the patch is easily
> demonstrated with a test?

I'll try to come up with a test in a reroll.

Thanks,
Stefan