From: Stefan Beller <sbeller@google.com>
Date: Fri, 25 Aug 2017 17:19:47 GMT
Subject: Re: [PATCH] usage_with_options: omit double new line on empty option list
Message-ID: <CAGZ79ka-PSt95TjVaUVf8yTZCdP8XuSfhJjBowJmgJbV2t0Tkg@mail.gmail.com>
In-Reply-To: <xmqq7exrtvl1.fsf@gitster.mtv.corp.google.com>

On Fri, Aug 25, 2017 at 10:18 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Stefan Beller <sbeller@google.com> writes:
>
>> Currently the worktree command gives its usage, when no subcommand is
>> given. However there are no general options, all options are related to
>> the subcommands itself, such that:
>>
>>     $ git worktree
>>     usage: git worktree add [<options>] <path> [<branch>]
>>        or: git worktree list [<options>]
>>        or: git worktree lock [<options>] <path>
>>        or: git worktree prune [<options>]
>>        or: git worktree unlock <path>
>>
>>
>>     $
>>
>> Note the two empty lines at the end of the usage string. This is because
>> the toplevel usage is printed with an empty options list.
>>
>> Only print one new line after the usage string if the option list is empty.
>
> Good find.  Shouldn't the last word in the sentence "non-empty", though?\

Yes.

Originally I wrote a lot more and then deleted it all, mixing up the negations
of what I was trying to say.