From: Stefan Beller Date: Mon, 01 May 2017 16:52:20 GMT Subject: Re: [PATCH 5/6] submodule: improve submodule_has_commits Message-ID: In-Reply-To: <20170430231434.GA70010@google.com> On Sun, Apr 30, 2017 at 4:14 PM, Brandon Williams wrote: > This hunk of logic is essentially a copy and paste from elsewhere in the > file. Essentially both code paths were essentially doing the same thing > (checking if a submodule has a commit) but one of the code paths included > this logic to ensure that it was reachable from a ref in the submodule. > In order to merge the two code paths, I included that logic here. yes, I get that. The question is whether the other code path omitted the check intentionally or just missed it (Is it a bug or feature to have this check in that code path now)?