From: Stefan Beller <sbeller@google.com>
Date: Tue, 31 Oct 2017 21:46:00 GMT
Subject: Re: [PATCH v3 0/8] convert diff flags to be stored in a struct
Message-ID: <CAGZ79kZytrzDRsEU8Od3rZBPbWYqJQiQ5w0PE6hxVR-SbE2MqA@mail.gmail.com>
In-Reply-To: <20171031181911.42687-1-bmwill@google.com>

On Tue, Oct 31, 2017 at 11:19 AM, Brandon Williams <bmwill@google.com> wrote:
> Changes in v3:
>  * Now always pass struct diff_flags by reference and don't return the struct
>    but rather modify the passed in struct.
>  * Don't clear TEXTCONV_SET_VIA_CMDLINE when --no-textconv is passed
>  * added additional patches (set out separately before) to remove the macros
>    and change the struct members to lowercase

I have reviewed this version and the functionality introduced
looks good to me. My only nits were regarding style and typos.

Thanks,
Stefan