From: Stefan Beller <sbeller@google.com>
Date: Fri, 12 Jun 2015 21:43:19 GMT
Subject: Re: [PATCH 2/3] pkt-line: tighten sideband PACK check when tracing
Message-ID: <CAGZ79kZs8snjB1Yi+Z3KctjHZN6VM6nRcHZ5Aa-iODcFxa7Gfg@mail.gmail.com>
In-Reply-To: <20150612214152.GA26217@peff.net>

On Fri, Jun 12, 2015 at 2:41 PM, Jeff King <peff@peff.net> wrote:
> On Fri, Jun 12, 2015 at 02:39:01PM -0700, Stefan Beller wrote:
>
>> > -       if (starts_with(buf, "PACK") || starts_with(buf + 1, "PACK")) {
>> > +       if (starts_with(buf, "PACK") || starts_with(buf, "\1PACK")) {
>>
>> This answers the question on the previous patch actually, maybe the
>> code could be improved to
>>
>>     if (is_sidechannel(out, ...)
>>         out++;
>>     if (starts_with(buf, "PACK") {
>>         ...
>
> If it's not a PACK, then we don't want to skip past the side-channel
> character (we show it as part of the trace).
>
> Hopefully the end result after patch 3 reads well, as it sets an
> explicit "sideband" flag.

Yeah, I just looked at that, and realized I should not worry about
these first two patches
as the line is deleted anyway. :( Writing faster than I can think.

>
> -Peff