From: Stefan Beller <sbeller@google.com>
Date: Mon, 26 Mar 2018 21:05:11 GMT
Subject: Re: [PATCH 1/1] repository.h: add comment and clarify repo_set_gitdir
Message-ID: <CAGZ79kZp-oxowhguARiaSY713-k5NLpMPVFA8G2GD2Vy4KxoTw@mail.gmail.com>
In-Reply-To: <CAGZ79ka0ptbwHU0Ym7aGm86o+YG27goHR6iS3uf5yUkj0Uj15w@mail.gmail.com>

On Mon, Mar 26, 2018 at 2:04 PM Stefan Beller <sbeller@google.com> wrote:



> On Fri, Mar 23, 2018 at 8:55 AM Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
wrote:
> >
> > The argument name "optional" may mislead the reader to think this
> > option could be NULL. But it can't be. While at there, document a bit
> > more about struct set_gitdir_args.
> >
> > Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>

> Reviewed-by: Stefan Beller <sbeller@google.com>

Uh, not so fast. Is it worthwhile to align the parameter name in
the c file as well?