From: Stefan Beller Date: Fri, 23 Jun 2017 20:13:03 GMT Subject: Re: [PATCHv2 04/25] diff.c: introduce emit_diff_symbol Message-ID: In-Reply-To: On Fri, Jun 23, 2017 at 1:07 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> diff --git a/new.txt b/new.txt >> index fa69b07..412428c 100644 >> Binary files a/new.txt and b/new.txt differ >> >> could be buffered as >> DIFF_SYMBOL_DIFF_START + new.txt >> DIFF_SYMBOL_INDEX_MODE + fa69b07 412428c "non-executable" flag >> DIFF_SYMBOL_BINARY_FILES + new.txt > > Hopefully this is an oversimplified example and I'd assume that you > will do the right thing when showing a renamed filepair by allowing > both old and new paths that could be different? Yes, this is simplified to drive the point of having as little data as possible, so I thought we might have a flag that says "same file name" instead of giving the file name twice. We do not do such an optimization yet.