From: Stefan Beller <sbeller@google.com>
Date: Tue, 13 Sep 2016 21:42:16 GMT
Subject: Re: [PATCH 01/16] t1007: factor out repeated setup
Message-ID: <CAGZ79kZQd2+TyceLmnTcv6rNGeKuyQhtvepvzcHw48WqOL4J4Q@mail.gmail.com>
In-Reply-To: <20160913032312.yheky2o25lmibvmb@sigill.intra.peff.net>

On Mon, Sep 12, 2016 at 8:23 PM, Jeff King <peff@peff.net> wrote:
> We have a series of 3 CRLF tests that do exactly the same
> (long) setup sequence. Let's pull it out into a common setup
> test, which is shorter, more efficient, and will make it
> easier to add new tests.
>
> Note that we don't have to worry about cleaning up any of
> the setup which was previously per-test; we call pop_repo
> after the CRLF tests, which cleans up everything.
>
> Signed-off-by: Jeff King <peff@peff.net>

This makes sense and looks good,
Thanks,

Reviewed-by: Stefan Beller <sbeller@google.com>