From: Stefan Beller <sbeller@google.com>
Date: Thu, 03 Aug 2017 20:26:03 GMT
Subject: Re: [PATCH v2 08/15] unpack-trees: don't respect submodule.update
Message-ID: <CAGZ79kZOLkJEJE-Rtid5LfmwgQ_AVnC0Mm-GwQJFOL+1SWB-nw@mail.gmail.com>
In-Reply-To: <20170803182000.179328-9-bmwill@google.com>

On Thu, Aug 3, 2017 at 11:19 AM, Brandon Williams <bmwill@google.com> wrote:
> The 'submodule.update' config was historically used and respected by the
> 'submodule update' command because update handled a variety of different
> ways it updated a submodule.  As we begin teaching other commands about
> submodules it makes more sense for the different settings of
> 'submodule.update' to be handled by the individual commands themselves
> (checkout, rebase, merge, etc) so it shouldn't be respected by the
> native checkout command.
>
> Also remove the overlaying of the repository's config (via using
> 'submodule_config()') from the commands which use the unpack-trees
> logic (checkout, read-tree, reset).

That was a mistake that I introduced with the checkout series.

Thanks for fixing it.