From: Stefan Beller <sbeller@google.com>
Date: Thu, 18 Oct 2018 19:09:16 GMT
Subject: Re: [PATCH 4/9] submodule.c: move global changed_submodule_names into fetch submodule struct
Message-ID: <CAGZ79kZHhmoBf26z3_Lk-yQEXztpGdWX-FfsRnvaKRCwETZ9XA@mail.gmail.com>
In-Reply-To: <20181017212624.196598-1-jonathantanmy@google.com>

On Wed, Oct 17, 2018 at 2:26 PM Jonathan Tan <jonathantanmy@google.com> wrote:
>
> > The `changed_submodule_names` are only used for fetching, so let's make it
> > part of the struct that is passed around for fetching submodules.
>
> Keep the titles of commit messages to 50 characters or under.

renamed

>
> > +static void calculate_changed_submodule_paths(
> > +     struct submodule_parallel_fetch *spf)
>
> Instead of taking the entire struct, could this just take the list of
> changed submodule names instead?

I think so, done.