From: Stefan Beller <sbeller@google.com>
Date: Fri, 27 Oct 2017 17:29:01 GMT
Subject: Re: [PATCH v3] merge-recursive: check GIT_MERGE_VERBOSITY only once
Message-ID: <CAGZ79kZ9EV=qaYyuA3kfuQ04EhLWax52MhtkmGJto2Lommc_SQ@mail.gmail.com>
In-Reply-To: <bd7eb593-75f9-0dd1-9dff-9dc420532217@samsung.com>

On Wed, Oct 25, 2017 at 6:03 AM, Andrey Okoshkin <a.okoshkin@samsung.com> wrote:
> Get 'GIT_MERGE_VERBOSITY' environment variable only once in
> init_merge_options() and store the pointer to its value for the further check.
> No intervening calls to getenv(), putenv(), setenv() or unsetenv() are done
> between the initial getenv() call and the consequential result pass to strtol()
> as these environment related functions could modify the string pointer returned
> by the initial getenv() call.
>
> Signed-off-by: Andrey Okoshkin <a.okoshkin@samsung.com>

This is
Reviewed-by: Stefan Beller <sbeller@google.com>