From: Stefan Beller Date: Fri, 19 Oct 2018 17:04:17 GMT Subject: Re: [PATCH v2] diff: don't attempt to strip prefix from absolute Windows paths Message-ID: In-Reply-To: <2ca9d427-38fb-ff6e-4e2f-1947d86e6273@kdbg.org> > +test_expect_success 'diff --no-index from repo subdir with absolute paths' ' I was late looking at the test, and was about to propose to guard it to run only on Windows (as this test seems of little use in other OS), but after thinking about it I think we should keep it as-is, as there may be other OS that have interesting absolute path which I may be unaware of. Reviewed-by: Stefan Beller