From: Stefan Beller Date: Fri, 23 Sep 2016 05:47:17 GMT Subject: Re: [PATCH 1/2] ls-files: adding support for submodules Message-ID: In-Reply-To: <20160923034113.4rnps3nogvzxkfjx@sigill.intra.peff.net> On Thu, Sep 22, 2016 at 8:41 PM, Jeff King wrote: >> * As Stefan alluded to (much) earlier, it might be a better idea >> to have these 'prefix' as the global option to "git" potty, not >> to each subcommand that happens to support them; > > That seems like it would be nice, but there's going to be an interim > period where some commands do not respect the global "--prefix" at all > (in the worst case, consider a third party command). My current line of thinking is to have a new flag in command struct in git.c to enable the global --prefix, (c.f. RUN_SETUP | NEED_WORK_TREE) so we'd have a ALLOW_OUTSIDE_PREFIX flag which can be used to enable this feature. In case that flag is not set, but a user tries a --prefix= we can still die("nope, we don't do that");