From: Stefan Beller <sbeller@google.com>
Date: Tue, 24 Apr 2018 00:38:24 GMT
Subject: Re: [PATCH 9/9] cache.h: allow sha1_object_info to handle arbitrary repositories
Message-ID: <CAGZ79kYzUbR-OSUn-174f9SwKjNQ7LTw2FcSiSpnZmmdPrAuMA@mail.gmail.com>
In-Reply-To: <20180424003414.GB245996@genre.crustytoothpaste.net>

On Mon, Apr 23, 2018 at 5:34 PM, brian m. carlson
<sandals@crustytoothpaste.net> wrote:
> On Mon, Apr 23, 2018 at 04:43:27PM -0700, Stefan Beller wrote:
>> This involves also adapting sha1_object_info_extended and a some
>> internal functions that are used to implement these. It all has to
>> happen in one patch, because of a single recursive chain of calls visits
>> all these functions.
>
> Ah, yes, I remember that recursive call chain.
>
> Anyway, other than the one item I mentioned earlier, this series looked
> good to me.

Thanks for the quick review!

Well, this very paragraph that you quote also mentions
*sha1*_object_info_extended, so I'll fix that, too

I'll wait until tomorrow for a resend to give others
the opportunity to weigh in as well.

Thanks,
Stefan