From: Stefan Beller <sbeller@google.com>
Date: Wed, 31 Aug 2016 21:46:10 GMT
Subject: Re: [PATCH v13 02/14] apply: rename and move opt constants to apply.h
Message-ID: <CAGZ79kYzOh-trnnc2JH9QX21DX=6nz=q0M99tbpU_Q68tmH0Qw@mail.gmail.com>
In-Reply-To: <20160827184547.4365-3-chriscool@tuxfamily.org>

On Sat, Aug 27, 2016 at 11:45 AM, Christian Couder
<christian.couder@gmail.com> wrote:
>  extern int check_apply_state(struct apply_state *state, int force_apply);
>

With greater scope comes greater responsibility. Nit of the day:
In case a reroll is necessary, consider putting a comment here.
(What are these constants? what do they control? How/where do I use them?)

> +#define APPLY_OPT_INACCURATE_EOF       (1<<0)
> +#define APPLY_OPT_RECOUNT              (1<<1)
> +