From: Stefan Beller <sbeller@google.com>
Date: Mon, 15 May 2017 23:12:30 GMT
Subject: Re: [PATCH 14/19] diff.c: convert word diffing to use emit_line_*
Message-ID: <CAGZ79kYx18HZGOLfN7jGzoG0DAEb7O+=L=7uZ07fDsNRK0ic_g@mail.gmail.com>
In-Reply-To: <f49dc4f8-cc83-934f-e582-79efdc613f70@google.com>

On Mon, May 15, 2017 at 3:40 PM, Jonathan Tan <jonathantanmy@google.com> wrote:
>
> I suspect that this will need to be refactored more thoroughly. Here, for
> example, emit_line (which prints the prefix) is printed nearly
> unconditionally, whereas in the original version, "fputs(line_prefix, fp)"
> is only printed when "print" is true.

Yes, manual testing confirms this is the case. Maybe I should to add a test
for "git diff --word-diff --line-prefix"

Thanks,
Stefan