From: Stefan Beller Date: Wed, 14 Oct 2015 20:27:38 GMT Subject: Re: [PATCH 07/26] mailinfo: move global "line" into mailinfo() function Message-ID: In-Reply-To: <1444778207-859-8-git-send-email-gitster@pobox.com> On Tue, Oct 13, 2015 at 4:16 PM, Junio C Hamano wrote: > The mailinfo() function is the only one that wants the "line_global" > to be directly touchable. Note that handle_body() has to be passed > this strbuf so that it sees the "first line of the input" after the > loop in this function processes the headers. It feels a bit dirty > that handle_body() then keeps reusing this strbuf to read more lines > and does its processing, but that is how the code is structured now. > > Signed-off-by: Junio C Hamano Ok, that is exactly what I thought about squashing into patch 6. A separate patch will do too.