From: Stefan Beller <sbeller@google.com>
Date: Sat, 03 Feb 2018 00:31:43 GMT
Subject: Re: [PATCH v7 18/31] merge-recursive: make a helper function for cleanup for handle_renames
Message-ID: <CAGZ79kYuiE31dQ7X45x+ZkF8t1ugMfzhoq_yh-j4cGy22P7aqQ@mail.gmail.com>
In-Reply-To: <20180130232533.25846-19-newren@gmail.com>

On Tue, Jan 30, 2018 at 3:25 PM, Elijah Newren <newren@gmail.com> wrote:
> In anticipation of more involved cleanup to come, make a helper function
> for doing the cleanup at the end of handle_renames.  Rename the already
> existing cleanup_rename[s]() to final_cleanup_rename[s](), name the new
> helper initial_cleanup_rename(), and leave the big comment in the code
> about why we can't do all the cleanup at once.
>
> Signed-off-by: Elijah Newren <newren@gmail.com>

This mostly touches new code of the series, so it feels a bit unnecessary.
I don't feel strongly about it being a separate patch, as the patches up to
now are easy to review. (and squashing may harm reviewability)

But the code makes sense.

Stefan