From: Stefan Beller <sbeller@google.com>
Date: Tue, 13 Sep 2016 22:40:24 GMT
Subject: Re: [RFC/PATCH 01/17] diff: move line ending check into emit_hunk_header
Message-ID: <CAGZ79kYriQpGd+V00c+90iTfpFo8tR2Os=rYBZR28p07mySeXQ@mail.gmail.com>
In-Reply-To: <848f36c9-4ac9-5316-1143-c47b48790847@web.de>

On Tue, Sep 13, 2016 at 7:42 AM, René Scharfe <l.s.r@web.de> wrote:

>>
>>         strbuf_add(&msgbuf, line + len, org_len - len);
>> +       if (line[org_len - 1] != '\n')
>> +               strbuf_addch(&msgbuf, '\n');
>> +
>
>
> Using strbuf_complete_line() would be nicer.

That makes sense!

Thanks,
Stefan