From: Stefan Beller <sbeller@google.com>
Date: Thu, 22 Jan 2015 23:48:30 GMT
Subject: Re: [PATCH v2 1/4] apply.c: typofix
Message-ID: <CAGZ79kYpaDs10J8WxdWwW1ojeeddQ+squUXYg1yuYVxOhzK__w@mail.gmail.com>
In-Reply-To: <xmqqd266s7qa.fsf@gitster.dls.corp.google.com>

On Thu, Jan 22, 2015 at 3:42 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Stefan Beller <sbeller@google.com> writes:
>
>>> -        * it might with whitespace fuzz. We haven't been asked to
>>> +        * it might with whitespace fuzz. We weren't asked to
>>
>> (not a native speaker):
>> A quick websearch reveals "We haven't been asked to ..."
>> is quite commonly used in the web. So it's more of a grammar fix or a
>> rewording of a comment instead of a typofix(which I assume are miss
>> spellings)
>
> Correct; it is not grammo or typo fix, but is a rephrasing to match
> the tense with what follows (i.e. we weren't asked to ignore; we
> were asked to fix).
>

Ok, I realized I missed my conclusion in the first mail: The commit message
and what the patch actually does, do not match.