From: Stefan Beller <sbeller@google.com>
Date: Thu, 23 Mar 2017 23:11:05 GMT
Subject: Re: [PATCH 2/7] submodule.c: convert is_submodule_modified to use strbuf_getwholeline_fd
Message-ID: <CAGZ79kYkqgY8n=C2ms8rsaRz9iZ66p_YXDfm9tR=MymuH-HHPw@mail.gmail.com>
In-Reply-To: <CAGZ79kYPdGVBUnTgGyiBB5ApC9eS14p7n1QjEWApSrmF38t9Rw@mail.gmail.com>

On Thu, Mar 23, 2017 at 4:04 PM, Stefan Beller <sbeller@google.com> wrote:
>
> We could have had closing before the child finished before as well:
> * the first read happens with strbuf_read(&buf, cp.out, 1024);

The 1024 is only a hint. So it actually reads the output in full.

So I guess I'll come up with a test for SIGPIPE, then.