From: Stefan Beller <sbeller@google.com>
Date: Tue, 03 Feb 2015 19:44:26 GMT
Subject: Re: [PATCH v2 3/4] apply: do not read from beyond a symbolic link
Message-ID: <CAGZ79kYkT_1cKgn8_JseHovnXoeO1Hi5FFPE9k7T6qDXLVY_FA@mail.gmail.com>
In-Reply-To: <xmqq1tm6ss4z.fsf@gitster.dls.corp.google.com>

On Tue, Feb 3, 2015 at 11:37 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Stefan Beller <sbeller@google.com> writes:
>
>> On Mon, Feb 2, 2015 at 3:27 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>> +       test_must_fail git apply --index patch
>>> +
>>> +'
>>
>> Is the empty line between the last test_must_fail and the closing `'`
>> intentional?
>
> I think I just mimicked the previous existing one, but I can go with
> the version without.

It was really a honest question. I've seen and written and sent tests
without such an ending
empty line and it seemed to be ok.

Maybe my email was more of "Note to self: this is also a valid style
used in the test suite
at some places"