From: Stefan Beller <sbeller@google.com>
Date: Wed, 11 May 2016 23:57:40 GMT
Subject: Re: [PATCH 0/7] submodule groups
Message-ID: <CAGZ79kYj2Vs-Bp_6Fya4kDzpo1_9TouSPq0PBrwJSV7q5RScjA@mail.gmail.com>
In-Reply-To: <xmqqh9e4i2av.fsf@gitster.mtv.corp.google.com>

On Wed, May 11, 2016 at 4:48 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
>>>   git ls-files . :(file-size:>1024k)
>>
>> I somehow do not think this is a way normal people (read: end users)
>> would want to interact with Git.  Pathspec is about "paths" and
>> various ways to match them.  It is not about contents that happens
>> to be currently named by that path.  Don't tie types or sizes to it.
>
> To clarify, think what that non-pathspec means when used like this:
>
>     $ git diff :(size>1M)
>     $ git log --follow :(size>1M)
>
> Which side of comparison does the "size" thing apply?  Either, both,
> randomly?  More importantly, what use case of users do these
> commands serve?
>
> That is why I said that pathspec should never consider anything but
> the pathname string you see.

I see. That is bad indeed. So I'll go back and finish the submodulespec
to present.

Thanks,
Stefan