From: Stefan Beller <sbeller@google.com>
Date: Fri, 02 Feb 2018 23:41:48 GMT
Subject: Re: [PATCH v7 14/31] merge-recursive: fix leaks of allocated renames and diff_filepairs
Message-ID: <CAGZ79kYdUOWp4AQAv+7bWxe6f2ewd3=L87CkRd6LKBLF_TroXA@mail.gmail.com>
In-Reply-To: <20180130232533.25846-15-newren@gmail.com>

On Tue, Jan 30, 2018 at 3:25 PM, Elijah Newren <newren@gmail.com> wrote:
> get_renames() has always zero'ed out diff_queued_diff.nr while only
> manually free'ing diff_filepairs that did not correspond to renames.
> Further, it allocated struct renames that were tucked away in the
> return string_list.  Make sure all of these are deallocated when we
> are done with them.
>
> Signed-off-by: Elijah Newren <newren@gmail.com>

Thanks for spotting the memleaks and fixing them in here.

If this series takes longer to review/cook, this patch
could go in separately? (with the last patch undone :/)