From: Stefan Beller <sbeller@google.com>
Date: Fri, 18 Nov 2016 20:10:09 GMT
Subject: Re: [PATCH v4 0/6] recursively grep across submodules
Message-ID: <CAGZ79kY_OfpXpuFfHYQmJJeuthu5P699V4LPytj90XtETmiW_Q@mail.gmail.com>
In-Reply-To: <1479499135-64269-1-git-send-email-bmwill@google.com>

On Fri, Nov 18, 2016 at 11:58 AM, Brandon Williams <bmwill@google.com> wrote:
> This revision of this series should address all of the problems brought up with
> v3.
>
> * indent output example in patch 5/6.
> * fix ':' in submodule names and add a test to verify.
> * cleanup some comments.
> * fixed tests to test the case where a submodule isn't at the root of a
>   repository.
> * always pass --threads=%d in order to limit threads to child proccess.
>
>
> -- interdiff based on 'bw/grep-recurse-submodules'

Thanks for interdiff!

I only skimmed the patches, but rather reviewed this interdiff in detail.
The series looks good to me, no nits!

Thanks,
Stefan