From: Stefan Beller <sbeller@google.com>
Date: Fri, 14 Apr 2017 17:02:21 GMT
Subject: Re: [PATCH 3/2] ls-files: only recurse on active submodules
Message-ID: <CAGZ79kY_Faantt9s3aBrWk6F9vDaKidjYpWt0be00w1vXu9PWg@mail.gmail.com>
In-Reply-To: <CA+P7+xoY-FFXEkPgQBA4=Twq+G5YZrHkBqiO+sKHcGJe7xt7vw@mail.gmail.com>

On Fri, Apr 14, 2017 at 9:33 AM, Jacob Keller <jacob.keller@gmail.com> wrote:
>
> Never mind. git ls-files doesn't support showing files for a specific
> ancient history. (I guess you'd use ls-tree for that?). I'm guessing
> we want to run in the actual work-tree for ls-files here.
>
> Does "is_submodule_initialized()" going to ensure that we only operate
> on a submodule that's currently checked out?

I think for that we rather want to use is_submodule_populated.
And I think it would make sense as well to check for that instead
of the initialized state.

Thanks,
Stefan