From: Stefan Beller <sbeller@google.com>
Date: Wed, 11 May 2016 17:26:15 GMT
Subject: Re: [PATCH 2/7] submodule add: label submodules if asked to
Message-ID: <CAGZ79kYWg08Cz0oznLSOryvXvYof+Y0=qbszF5r5fXqxr2HDMw@mail.gmail.com>
In-Reply-To: <xmqqlh3hl7mc.fsf@gitster.mtv.corp.google.com>

>> +cat >expect <<-EOF
>> +labelA
>> +labelB
>> +EOF
>> +
>> +test_expect_success 'submodule add records multiple labels' '
>
> The existing tests in this file may be littered with this bad
> construct, but please do not add more example of running things
> outside of test_expect_{success,failure} block unless there is a
> good reason to do so.

I thought that was the standard for tests as I have seen
them quite a few times. Looking for those "cat >expect ..." constructs
more closely they are often found inside tests as well. Makes sense
if the expectation is used for only one test.