From: Stefan Beller <sbeller@google.com>
Date: Tue, 13 Sep 2016 22:00:17 GMT
Subject: Re: [PATCH 06/16] diff: always try to set up the repository
Message-ID: <CAGZ79kYNfUmBG+9irQoZ+C6qfiiz0P7pGKHZVk-8569gk4+_EQ@mail.gmail.com>
In-Reply-To: <20160913032336.cur3rrzpgepulqi6@sigill.intra.peff.net>

On Mon, Sep 12, 2016 at 8:23 PM, Jeff King <peff@peff.net> wrote:

>   2. If you're in a subdirectory of a repository, then we
>      still try to read ".git/config", but it generally
>      doesn't exist. So "diff --no-index" there does not
>      respect repo config.

Nit:
So IIUC your cover letter even this /used/ to work but
broke only recently? So I feel like the message is a bit
misleading (i.e. you argue for a change in behavior instead of
calling it a bug fix for a regression. I think a bug fix for a regression
is harder to revert as compared to a "new" behavior)

I agree on the code, though.