From: Stefan Beller <sbeller@google.com>
Date: Mon, 24 Apr 2017 22:10:24 GMT
Subject: Re: [PATCH 13/53] notes-cache: convert to struct object_id
Message-ID: <CAGZ79kYKLin0=Yz33NO8tQrWUBbjBGU==2RCEeNZFLhV5j7oQw@mail.gmail.com>
In-Reply-To: <20170423213453.253425-14-sandals@crustytoothpaste.net>

On Sun, Apr 23, 2017 at 2:34 PM, brian m. carlson
<sandals@crustytoothpaste.net> wrote:
> Convert as many instances of unsigned char [20] as possible,  Update the

s/Update/update/ or s/,/./

Side remark: In all patches up to now you put a space between the char and
the [20] (or [40]), which is irritating to read (for me). I presume
putting it adjacent
to the char would offend others as that would violate our coding
style. So having
the whitespace in between "char" and the array makes sense.

Up and including this patch looks good.

Thanks,
Stefan