From: Stefan Beller <sbeller@google.com>
Date: Thu, 18 Aug 2016 18:06:23 GMT
Subject: Re: [PATCH v7 4/7] submodule: allow do_submodule_path to work if given gitdir directly
Message-ID: <CAGZ79kYK0_TC0AS_6Wqh4LA6xnj9xeZu7O1Gj5A+Y1h1ikKjHQ@mail.gmail.com>
In-Reply-To: <20160818005131.31600-5-jacob.e.keller@intel.com>

On Wed, Aug 17, 2016 at 5:51 PM, Jacob Keller <jacob.e.keller@intel.com> wrote:
> From: Jacob Keller <jacob.keller@gmail.com>
>
> Currently, do_submodule_path relies on read_gitfile, which will die() if
> it can't read from the specified gitfile. Unfortunately, this means that
> do_submodule_path will not work when given the path to a submodule which
> is checked out directly, such as a newly added submodule which you
> cloned and then "git submodule add". Instead, replace the call with
> resolve_gitdir. This first checks to see if we've been given a gitdir
> already.
>
> Because resolve_gitdir may return the same buffer it was passed, we have
> to check for this case as well, since strbuf_reset() will not work as
> expected here, and indeed is not necessary.
>
> Signed-off-by: Jacob Keller <jacob.keller@gmail.com>
> ---
>  path.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Looks good,
Thanks,
Stefan