From: Stefan Beller <sbeller@google.com>
Date: Tue, 15 Nov 2016 22:15:31 GMT
Subject: Re: [PATCH v3 1/4] serialize collection of changed submodules
Message-ID: <CAGZ79kYBf_B4ZQ7CoTt62ZR-qXhHNBEWem5K-r1eOPrUPYufrw@mail.gmail.com>
In-Reply-To: <67e11474d4fd8ada2652809cf14f6c4d96be55ff.1479221071.git.hvoigt@hvoigt.net>

On Tue, Nov 15, 2016 at 6:56 AM, Heiko Voigt <hvoigt@hvoigt.net> wrote:

> @@ -560,6 +575,31 @@ static void find_unpushed_submodule_commits(struct commit *commit,
>         diff_tree_combined_merge(commit, 1, &rev);
>  }
>
> +struct collect_submodule_from_sha1s_data {
> +       char *submodule_path;
> +       struct string_list *needs_pushing;
> +};
> +
> +static int collect_submodules_from_sha1s(const unsigned char sha1[20],
> +               void *data)
> +{
> +       struct collect_submodule_from_sha1s_data *me =
> +               (struct collect_submodule_from_sha1s_data *) data;

nit: no explicit cast needed when coming from void* ?