From: Stefan Beller <sbeller@google.com>
Date: Mon, 16 Jul 2018 19:14:39 GMT
Subject: Re: [PATCH 03/16] commit-reach: move commit_contains from ref-filter
Message-ID: <CAGZ79kY76rnp8VEBjzfcZ+kB7JWh+5urASWdAGkYejwGY21QJQ@mail.gmail.com>
In-Reply-To: <b9687d2b21c4560178a509572770e3a058582a8b.1531746010.git.gitgitgadget@gmail.com>

On Mon, Jul 16, 2018 at 6:00 AM Derrick Stolee via GitGitGadget
<gitgitgadget@gmail.com> wrote:

> +
> +int commit_contains(struct ref_filter *filter, struct commit *commit,
> +                   struct commit_list *list, struct contains_cache *cache)

[...]

> -
> -static int commit_contains(struct ref_filter *filter, struct commit *commit,
> -                          struct commit_list *list, struct contains_cache *cache)

All moved code, but this one, which was exposed to the public.
Might be worth calling out in the commit message?
While exposing it, it is a good idea to question its name and if
it is good enough for public use (I think it is -- despite not understanding
what the function does by its arguments; so bonus points for docs!)

Thanks,
Stefan